Skip to content

Add library/ prefix for image name - #11237

Closed
vanta wants to merge 2 commits into
testcontainers:mainfrom
vanta:patch-1
Closed

vanta wants to merge 2 commits into
testcontainers:mainfrom
vanta:patch-1

Conversation

@vanta

@vanta vanta commented Nov 21, 2025 •

Copy link
Copy Markdown

Ideally, such a change should be done to the 1.x release, as with the version 2.x, there is a way to pass a DockerImageName instance.

@vanta
vanta requested a review from a team as a code owner November 21, 2025 16:58
@eddumelendez

Copy link
Copy Markdown
Member

This should work already without changes. Thanks anyway.

@vanta

vanta commented Nov 24, 2025 •

Copy link
Copy Markdown
Author

@eddumelendez It's not working in our case - we have the ECR as a proxy to Docker Hub, and ECR cannot do it with _. It's a small change and should not harm.

Any chance to push it to 1.x release?

@eddumelendez

Copy link
Copy Markdown
Member

1.x is not released anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants