Skip to content
This repository was archived by the owner on Jul 24, 2019. It is now read-only.
This repository was archived by the owner on Jul 24, 2019. It is now read-only.

uniqueItems validator #16

Open
Open
uniqueItems validator#16

Description

@seagreen
seagreen
opened on Mar 31, 2014

(spec for uniqueItems validator)

It's incredibly slow the way it's currently written. Got any hints on how to check an []interface{} for uniqueness of elements?

Activity

  1. titanous commented on Mar 31, 2014

    @titanous
    titanous
    on Mar 31, 2014
    Member

    Hmm, are we just comparing simple objects like strings and numbers, or objects too?

  2. seagreen commented on Mar 31, 2014

    @seagreen
    seagreen
    on Mar 31, 2014
    ContributorAuthor

    Objects too: https://github.com/json-schema/JSON-Schema-Test-Suite/blob/develop/tests/draft4/uniqueItems.json#L40

  3. titanous commented on Mar 31, 2014

    @titanous
    titanous
    on Mar 31, 2014
    Member

    That's basically impossible to do in a performant way. Leave it for now. If it becomes an issue in the future we'll have to implement our own hash algorithm that can hash any object (ugh).

  4. seagreen commented on Apr 7, 2014

    @seagreen
    seagreen
    on Apr 7, 2014
    ContributorAuthor

    Link to the abandoned branch for posterity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions