Repository navigation
Record both arms at the compact-WY factor row split (e6ee2d3) - #7
Merged
Merged
Conversation
`tensor4all/faer#6` splits the deep half of `upgrade_householder_factor`'s flat branch -- `T += V_bot^H V_bot`, an `n x n` output reduced over every row below the basis' diagonal, one serial kernel per task (0.271 ms at 8T at `m = 4096, n = 16`, against 0.040 split). Its partials are `n x n` and only the strict upper triangle is stored, so it needs no depth-against-width gate and the split pays at every size: 6.7x at 4096x16, 4.6x at 1024x16, 3.0x at 512x16. The pin moves to `e6ee2d3`, one complete set of each arm is measured from scratch, and both cells read `full` and `current`. Against the vendor rows of the two pairs as the floor (1.000-1.002 median, p10-p90 0.983-1.023 over ~490 cells each), the faer medians move 1.005 / 1.004 / 1.001 / 0.999 at 1T and 1.003 / 1.001 / 0.993 / 0.857 at 8T over small, medium, large and tall: the tall regime is 14% faster overall. At 8T, `householder_factor` 4096x256 b1 c64 16.05 -> 13.35 ms (f64 5.63 -> 4.90), `qr` c64 42.76 -> 36.87, `rank_revealing_qr` c64 52.06 -> 44.78, `svd_thin` c64 84.77 -> 76.34 and f64 34.38 -> 26.89, with the 512x512 and 256x256 cells improving too and every 1T row unchanged. The cell this campaign started from -- `householder_factor` 4096x256 b1, 10.2x behind OpenBLAS at 8T when it was first recorded -- now reads 1.08x there and 0.46x in f64. The worklog records the phase split and the one part left: the panel, whose grain is a single reflector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this moves
pins/tlinalg-rs.rev->e6ee2d3304e042926c77cda7b81e58c871a98919(the merge oftensor4all/tlinalg-rs#50, which consumestensor4all/faer#6), both arms re-recorded from scratch, both cellsfullandcurrent:result/zen5-cpu/tlinalg-kernels/e6ee2d3304e0-openblas.md(run20261013T071911Z)result/zen5-cpu/tlinalg-kernels/e6ee2d3304e0-mkl.md(run20261013T084748Z)Why
With the block apply's reduction split (#4, #5), the tall c64
householder_factorcell was 16.05 ms against OpenBLAS's 12.50, and re-separating its phases showed the compact-WY factor build was still 2.7 ms with no scaling at all --upgrade_householder_factor's flat branch reducesV_bot^H V_botover every row below the basis' diagonal with ann x noutput, one serial kernel per task (0.271 ms at 8T atm = 4096, n = 16).faer#6splits its rows too. Its partials aren x neach and only the strict upper triangle is stored, so unlike the block apply's split it needs no depth-against-width gate and pays at every size (6.7x at 4096x16, 4.6x at 1024x16, 3.0x at 512x16).The evidence in this record
Medians of
after / beforeover each regime's cells, vendor rows of the two pairs as the floor:smallmediumlargetallfaer-1laneat 1Tfaer-poolat 8TVendor floor: 1.000-1.002 median, p10-p90 0.983-1.023 over ~490 cells per row per arm.
Every blocked QR path builds this factor, so the change is wider than one cell -- at 8T (before -> after, vendors from the same runs):
householder_factor4096x256 b1 c64householder_factor4096x256 b1 f64qr4096x256 b1 c64rank_revealing_qr4096x256 b1 c64svd_thinf64 4096x256 b1householder_factor512x512 b1 c64householder_apply256x256 b4 f64Every 1T row is unchanged, and the families that build no compact-WY factor (
lu_*,cholesky,eigh*,svd_values,triangular_solve) sit inside the floor.Where the family that started this stands
householder_factor4096x256 b1 was 10.2x behind OpenBLAS at 8T when this campaign first recorded it, 1.55x after the blocking, and reads 1.08x in c64 and 0.46x in f64 now. The tall c64 cells that still lose areqr(1.43x OpenBLAS, 1.23x MKL) andrank_revealing_qr, which call faer's own blocked QR rather than tlinalg's kernels; the worklog and the fork'sPATCHSET.mdcarry the one part left inside tlinalg's path -- the panel, ~5 ms of that cell's 13.4, whose grain is a single reflector.Checks
scripts/validate_run.pyon both manifests: ok.scripts/gen_index.py --check: current.