Skip to content

fix: use MAX/MIN instead of the deprecated max_value()/min_value() - #26

Merged
shinaoka merged 2 commits into
mainfrom
fix/deprecated-max-value
Oct 11, 2026
Merged

shinaoka merged 2 commits into
mainfrom
fix/deprecated-max-value

Conversation

@shinaoka

Copy link
Copy Markdown
Member

The lint job, and so main, is red on four clippy errors that have nothing to do with any recent change:

error: use of deprecated associated function core::num::<impl u16>::max_value
  --> hdf5/src/hl/filters.rs:477:47
error: use of deprecated associated function core::num::<impl u8>::max_value
  --> hdf5/src/hl/filters.rs:484:46
error: use of deprecated associated function core::num::<impl u64>::max_value
  --> hdf5/src/hl/plist/file_access.rs:358:22
error: use of deprecated associated function core::num::<impl u64>::max_value
  --> hdf5/src/hl/plist/file_access.rs:424:42

max_value()/min_value() become MAX/MIN. No behaviour change; cargo clippy --lib is clean with the current stable toolchain.

This blocks every pull request, since lint is a required check, so it is split out rather than folded into an unrelated change.

@shinaoka
shinaoka merged commit b5d7fde into main Oct 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant