Skip to content

chore: add the generated code of the Streams API - #2128

Draft
moetemp wants to merge 2 commits into
moe/activity-workflow-task-infofrom
moe/streams-generated-code
Draft

moetemp wants to merge 2 commits into
moe/activity-workflow-task-infofrom
moe/streams-generated-code

Conversation

@moetemp

@moetemp moetemp commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

What changed?

This PR adds the generated code of the Streams API, and nothing else. The files are what poe gen-protos writes at the head of #2129.

  • The nexgen output under temporalio/nexus/system/stream_service/.
  • The Stream _pb2 modules, and the __init__.py files of their packages.
  • The Stream part of temporalio/bridge/_visitor.py, and the two exports in temporalio/workflow/__init__.py.

Why?

It's the base of #2129, so that #2129 shows only the hand-written change. Its own base is #2127.

How did you test it?

This branch doesn't pass CI alone. The generated code calls support functions, such as default_producer(), that #2129 adds. The script that writes these files and the tests are in #2129 too.

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

These are the files that `poe gen-protos` writes for the Stream service. They are in a PR of
their own, so that the hand-written change shows alone.
…eam.

The new Stream WIT gives the Workflow target `append` and `close`, so the generated Workflow `Stream` has them and `async with` closes it.
@moetemp
moetemp removed this pull request from stack #2130 November 15, 2026 08:27
@moetemp
moetemp force-pushed the moe/activity-workflow-task-info branch from dfc0ba0 to 1a718b8 Compare November 15, 2026 18:51
@moetemp
moetemp force-pushed the moe/streams-generated-code branch from 434ddd3 to d70f12d Compare November 15, 2026 18:51
@moetemp
moetemp force-pushed the moe/activity-workflow-task-info branch from 1a718b8 to 88cc83e Compare November 15, 2026 20:23
@moetemp
moetemp force-pushed the moe/streams-generated-code branch from d70f12d to 6b44118 Compare November 15, 2026 20:23
@moetemp
moetemp force-pushed the moe/activity-workflow-task-info branch from 88cc83e to e982e2a Compare November 16, 2026 17:14
@moetemp
moetemp force-pushed the moe/streams-generated-code branch from 6b44118 to f330b20 Compare November 16, 2026 17:14
@moetemp
moetemp force-pushed the moe/activity-workflow-task-info branch from e982e2a to 2c3fa47 Compare November 16, 2026 17:33
@moetemp
moetemp force-pushed the moe/streams-generated-code branch from f330b20 to 31151f2 Compare November 16, 2026 17:33
@moetemp
moetemp force-pushed the moe/activity-workflow-task-info branch from 2c3fa47 to 1bb78ad Compare November 16, 2026 19:42
@moetemp
moetemp force-pushed the moe/streams-generated-code branch from 31151f2 to e8898ec Compare November 16, 2026 19:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant