Skip to content

Conversation

@xepozz
Copy link
Collaborator

@xepozz xepozz commented Jan 8, 2026

What was changed

Drop internal/promise v2 support

image

test.3.0.txt

All tests in the https://github.com/temporalio/features passed

Tests in https://github.com/temporalio/roadrunner-temporal passed as well

 grep -A 1 '"name": "internal/promise"' tests/php_test_files/composer.lock
            "name": "internal/promise",
            "version": "3.4.1",
❯ CGO_ENABLED=0 go test -timeout 20m -v -race -failfast ./...
?       github.com/temporalio/roadrunner-temporal/v5    [no test files]
?       github.com/temporalio/roadrunner-temporal/v5/aggregatedpool     [no test files]
?       github.com/temporalio/roadrunner-temporal/v5/api        [no test files]
=== RUN   Test_CancellerNoListeners
--- PASS: Test_CancellerNoListeners (0.00s)
=== RUN   Test_CancellerListenerError
--- PASS: Test_CancellerListenerError (0.00s)
=== RUN   Test_CancellerListenerDiscarded
--- PASS: Test_CancellerListenerDiscarded (0.00s)
PASS
ok      github.com/temporalio/roadrunner-temporal/v5/canceller  (cached)
=== RUN   Test_Passthough
--- PASS: Test_Passthough (0.00s)
PASS
ok      github.com/temporalio/roadrunner-temporal/v5/dataconverter      (cached)
?       github.com/temporalio/roadrunner-temporal/v5/internal   [no test files]
?       github.com/temporalio/roadrunner-temporal/v5/internal/codec/proto       [no test files]
?       github.com/temporalio/roadrunner-temporal/v5/internal/logger    [no test files]
=== RUN   Test_MessageQueueFlushError
--- PASS: Test_MessageQueueFlushError (0.00s)
=== RUN   Test_MessageQueueFlushResponse
--- PASS: Test_MessageQueueFlushResponse (0.00s)
=== RUN   Test_MessageQueueCommandID
--- PASS: Test_MessageQueueCommandID (0.00s)
PASS
ok      github.com/temporalio/roadrunner-temporal/v5/queue      (cached)
?       github.com/temporalio/roadrunner-temporal/v5/registry   [no test files]

Why?

Solves #692

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
php Ready Ready Preview, Comment Jan 26, 2026 4:55pm

Request Review

@xepozz xepozz marked this pull request as ready for review January 8, 2026 09:06
@xepozz xepozz requested a review from wolfy-j as a code owner January 8, 2026 09:06
@xepozz xepozz linked an issue Jan 8, 2026 that may be closed by this pull request
@xepozz xepozz added Bug Something isn't working and removed Bug Something isn't working labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Minimal Composer requirements conflicts with react/promise v2

2 participants