fix: ignore psalm error #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roxblnfk
approved these changes
Jan 9, 2026
wolfy-j
reviewed
Jan 9, 2026
|
|
||
| private function drain(): void | ||
| { | ||
| /** @psalm-suppress PossiblyNullArrayOffset */ |
Collaborator
There was a problem hiding this comment.
what is the reasoning here?
Collaborator
Author
There was a problem hiding this comment.
In a separate PR's you may notice that static analysis is failed, e.g. https://github.com/temporalio/sdk-php/actions/runs/20845807591/job/59889027930
Collaborator
There was a problem hiding this comment.
It's okay to suppress false positives with annotations. However, this case doesn't seem like a false positive, but to be sure, you need to study the class usage context.
If you still want to put this in the backlog, use psalm:baseline. To fix it, you'll need to rewrite the code.
Collaborator
Author
There was a problem hiding this comment.
Ok I used psalm:baseline command instead
wolfy-j
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: