Skip to content

Conversation

@xepozz
Copy link
Collaborator

@xepozz xepozz commented Dec 20, 2025

What was changed

image

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@xepozz xepozz requested a review from wolfy-j as a code owner December 20, 2025 11:58
@vercel
Copy link

vercel bot commented Dec 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
php Ready Ready Preview, Comment Jan 26, 2026 4:17pm

Request Review

@roxblnfk
Copy link
Collaborator

In my opinion, the client stack trace in tests doesn't matter, that's why I haven't included it.
You just need to know which test line failed and with what message.

@xepozz
Copy link
Collaborator Author

xepozz commented Dec 20, 2025

It it.
There is a stacktrace which is useful to find and navigate to a client call, getResult() in DeploymentTest in this case.
It is better to have a clearer result than to have nothing.

Basically, errors shows some context, but current dumps only "workflow history for {method}": no stacktrace, no concrete class (only test method name), no additional context.

@roxblnfk
Copy link
Collaborator

Doesn't PHPUnit provide it?

@xepozz xepozz merged commit eba4a3e into master Jan 26, 2026
90 of 113 checks passed
@xepozz xepozz deleted the expressive-errors branch January 26, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants