Open
Conversation
kavink98
force-pushed
the
fix/remove-newtonsoft
branch
from
bb2db92 to
bdc1e93
Compare
Contributor
|
Looks good to me. I did a test merge with my latest changes (all the semantic units restructure) and there was only a few trivial merge conflicts and all the tests ran fine, so all the stuff deleted doesn't look to be necessary. Nice job cleaning up. |
Collaborator
|
Jsonhelp.cs - need to remove Newtonsoft reference @jasonshelley to investigate |
| @@ -1,5 +1,4 @@ | |||
| using Newtonsoft.Json; | |||
| using Newtonsoft.Json.Linq; | |||
| using Newtonsoft.Json.Linq; | |||
There was a problem hiding this comment.
Refactor to remove JObject.Parse and use alternate method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.