Skip to content

Fix burst mode not disabled when generating non-burst signals - #591

Closed
raywcm wants to merge 1 commit into
tektronix:mainfrom
raywcm:fix/burst-state-not-disabled
Closed

Fix burst mode not disabled when generating non-burst signals#591
raywcm wants to merge 1 commit into
tektronix:mainfrom
raywcm:fix/burst-state-not-disabled

Conversation

@raywcm

@raywcm raywcm commented Jun 4, 2026

Copy link
Copy Markdown

Problem

When generating a burst signal on an AFG followed by a non-burst signal via generate_function, the burst state is not reset. The non-burst signal remains affected by the previous burst settings, producing incorrect output.

Fix

Add an else branch to set_function_properties to disable burst state when burst_count is 0.

Closes #440

@raywcm
raywcm requested a review from a team as a code owner June 4, 2026 01:44
@tek-githubbot-1010
tek-githubbot-1010 requested a review from a team June 4, 2026 01:44
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@raywcm

raywcm commented Jun 4, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@v12ganesh

v12ganesh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The tm_devices contribution guidelines require signed commits. This commit is not currently showing as GitHub "Verified". Please sign the commit and update the PR.

@nfelt14

nfelt14 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Closing this PR based on a lack of interaction and updates.

@nfelt14 nfelt14 closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Burst mode for signal generation is not disabled when not used

4 participants