Fix burst mode not disabled when generating non-burst signals - #591
Closed
raywcm wants to merge 1 commit into
Closed
Fix burst mode not disabled when generating non-burst signals#591raywcm wants to merge 1 commit into
raywcm wants to merge 1 commit into
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
The tm_devices contribution guidelines require signed commits. This commit is not currently showing as GitHub "Verified". Please sign the commit and update the PR. |
Collaborator
|
Closing this PR based on a lack of interaction and updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When generating a burst signal on an AFG followed by a non-burst signal via
generate_function, the burst state is not reset. The non-burst signal remains affected by the previous burst settings, producing incorrect output.Fix
Add an
elsebranch toset_function_propertiesto disable burst state whenburst_countis 0.Closes #440