Skip to content

Fix TSP load_script not checking write_termination for long scripts - #590

Closed
raywcm wants to merge 1 commit into
tektronix:mainfrom
raywcm:fix/tsp-load-script-write-termination
Closed

raywcm wants to merge 1 commit into
tektronix:mainfrom
raywcm:fix/tsp-load-script-write-termination

Conversation

@raywcm

@raywcm raywcm commented Jun 4, 2026

Copy link
Copy Markdown

Problem

TSP devices have a max write of approximately 1000 characters before a write_termination character must exist. load_script() writes the entire script body in a single self.write() call, which fails when the script exceeds the max write size.

Fix

Extract the loadscript command into a variable so the caller can check the length and insert write_termination characters as needed before the max limit is exceeded.

Closes #500

@raywcm
raywcm requested a review from a team as a code owner June 4, 2026 01:40
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tek-githubbot-1010
tek-githubbot-1010 requested a review from a team June 4, 2026 01:41
@raywcm

raywcm commented Jun 4, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@v12ganesh

v12ganesh commented Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

The tm_devices contribution guidelines require signed commits. This commit is not currently showing as GitHub "Verified". Please sign the commit and update the PR.

@nfelt14

nfelt14 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Closing this PR based on a lack of interaction and updates.

@nfelt14 nfelt14 closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: TSP devices don't check for a write_termination character when loading a script

4 participants