fix: validate TSP loadscript write spans - #586
Closed
AjTheSpidey wants to merge 1 commit into
Closed
Conversation
|
|
Collaborator
|
This seems to be a duplicate of #581 |
Author
|
Closing this since #581 already covers it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #500 by checking the full loadscript command before it is sent to the instrument. The existing single-write behavior is kept, but the code now rejects any newline-delimited span longer than the TSP input limit, so a script line cannot run past the required write termination point. The check happens before the old script is deleted, so an invalid script body does not leave the device half-updated.
I added coverage in the SMU test for the 1000-character boundary and for rejecting the over-limit case before a write is sent. I also updated the unreleased changelog.
Tested locally on Windows with Python 3.14:
I also tried pre-commit run --all-files, but it did not finish locally even after a longer timeout, so I did not count that as passing.