Fix sentinel header select - #133
Merged
Merged
Conversation
…ields_testing # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
arokem
reviewed
Aug 17, 2026
| if not self._copy_safe: | ||
| to_dump = _append_last_offsets( | ||
| self.streamlines.copy()._offsets, self.header["NB_VERTICES"] | ||
| self.streamlines.copy()._offsets, tmp_header["NB_VERTICES"] |
Collaborator
There was a problem hiding this comment.
This seems the key line related to the title of the PR. Is there a test in place that fails without this change?
arokem
reviewed
Aug 17, 2026
| out = os.path.join(tmp_dir, "sub.trx") | ||
| tmm.save(sub, out) | ||
| loaded = tmm.load(out) | ||
| assert len(loaded.streamlines) == 5 |
Collaborator
There was a problem hiding this comment.
I am guessing this is the test I was asking about?
Collaborator
Author
There was a problem hiding this comment.
Yes, because of the mismatch between the actual length of the arrays vs the header this could cause problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the offset sentinel calculation during deepcopy and serialization of sliced or subsetted TrxFile instances created via .select(), to avoid a problem with header dimensions upon reload.
I discovered a bug when running old example (updating stuff from the poster to the new API)