STY: Prefer using pytest temporary path fixtures in tests - #126
Merged
arokem merged 2 commits intoAug 21, 2026
Conversation
jhlegarreta
force-pushed
the
sty/use-pytest-temp-path-fixture
branch
5 times, most recently
from
August 11, 2026 07:23
7c9fa9b to
87b3a41
Compare
Contributor
Author
|
This requires some more thinking. The memmap test file was doing trx-python/trx/tests/test_memmap.py Line 26 in 96876f4 But then all test functions requiring a temporary directory were using the same variable name in the context: trx-python/trx/tests/test_memmap.py Line 354 in 96876f4 So I do not believe the design was that correct, and this PR is probably uncovering that. |
jhlegarreta
force-pushed
the
sty/use-pytest-temp-path-fixture
branch
9 times, most recently
from
August 21, 2026 17:32
79f3fae to
1fe0c5c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 86.53% 86.49% -0.05%
==========================================
Files 13 13
Lines 2896 2887 -9
==========================================
- Hits 2506 2497 -9
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jhlegarreta
force-pushed
the
sty/use-pytest-temp-path-fixture
branch
from
August 21, 2026 17:33
1fe0c5c to
98aa419
Compare
Prefer using the `pytest` `tmp_path` fixture in tests over the standard library `tempfile.TemporaryDirectory()`: - Makes the code more readable as no additional context (and the associated indentation) required by the use of `TemporaryDirectory` is needed. - Simplifies path manipulation as they return a `pathlib.Path` object and thus, no recurrent casting to `Path` is necessary. - Increases consistency in temporary directory naming, and thus, eases maintenance. - Fixes ``` Shadows name 'tmp_dir' from outer scope ``` warnings across `test_memmap.py`. - Remove the unused/unnecessary `tmp_dir = get_trx_tmp_dir()` statement.
jhlegarreta
force-pushed
the
sty/use-pytest-temp-path-fixture
branch
from
August 21, 2026 17:35
98aa419 to
f99628c
Compare
Refactor `trx_tmp_dir` test:
- Do not parametrize an argument named `tmp_path`: that name is reserved
for `pytest`'s built-in fixture, and reusing it as a string parameter
is misleading/shadowing-prone.
- Clarify test intent by separating concerns:
- Keep the existing integration-style coverage (through load path
behavior),
- add a direct unit test for `get_trx_tmp_dir()` so the env-variable
contract is verified explicitly.
The previous test did not clearly test `get_trx_tmp_dir` itself; it
inferred behavior indirectly via `tmm.load(...)`.
- Replace symbolic "~" handling with explicit env-driven expectations
(home path value, `use_working_dir`, and unset env -> system temp
dir), which makes the “home” case non-misleading and properly
asserted.
- Deduplicate branch-specific assertions by deriving a single expected
parent directory per parametrized case.
- Use `monkeypatch` for `TRX_TMPDIR` setup/teardown to guarantee env
isolation and automatic cleanup, preventing cross-test leakage and
order-dependent failures.
jhlegarreta
force-pushed
the
sty/use-pytest-temp-path-fixture
branch
from
August 21, 2026 17:40
f99628c to
0296979
Compare
Contributor
Author
|
Re #126 (comment) No need for further action. Tests are passing. Pinging @arokem. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer using the
pytesttmp_pathfixture in tests:TemporaryDirectoryis needed.pathlib.Pathobject and thus, no recurrent casting toPathis necessary.Shadows name 'tmp_dir' from outer scopewarnings acrosstest_memmap.py.tmp_dir = get_trx_tmp_dir()statement.