Skip to content

STYLE: Prefer using f-strings - #121

Merged
arokem merged 2 commits into
tee-ar-ex:masterfrom
jhlegarreta:sty/prefer-f-strings
Aug 11, 2026
Merged

STYLE: Prefer using f-strings#121
arokem merged 2 commits into
tee-ar-ex:masterfrom
jhlegarreta:sty/prefer-f-strings

Conversation

@jhlegarreta

Copy link
Copy Markdown
Contributor

Prefer using f-strings.

Documentation:
https://peps.python.org/pep-0498/

@jhlegarreta
jhlegarreta force-pushed the sty/prefer-f-strings branch 3 times, most recently from 75603fe to b6cf8ae Compare August 7, 2026 18:04

@arokem arokem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See one local comment.

Comment thread trx/fetcher.py Outdated
@arokem

arokem commented Aug 10, 2026

Copy link
Copy Markdown
Member

Oh yes, see also CI failures.

@jhlegarreta
jhlegarreta force-pushed the sty/prefer-f-strings branch 6 times, most recently from 6cc6160 to 8e1448b Compare August 10, 2026 21:03
@jhlegarreta

Copy link
Copy Markdown
Contributor Author

👍- Failures are now related to the viz module business.

@jhlegarreta
jhlegarreta force-pushed the sty/prefer-f-strings branch from 8e1448b to 4a04e78 Compare August 11, 2026 07:05
@jhlegarreta
jhlegarreta force-pushed the sty/prefer-f-strings branch from 4a04e78 to 812e038 Compare August 11, 2026 07:38
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.34483% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.57%. Comparing base (96876f4) to head (a6ff4b9).

Files with missing lines Patch % Lines
trx/trx_file_memmap.py 68.75% 10 Missing ⚠️
trx/workflows.py 33.33% 6 Missing ⚠️
trx/io.py 0.00% 3 Missing ⚠️
trx/utils.py 0.00% 3 Missing ⚠️
trx/tests/test_io.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   63.55%   63.57%   +0.02%     
==========================================
  Files          12       12              
  Lines        2568     2570       +2     
==========================================
+ Hits         1632     1634       +2     
  Misses        936      936              
Flag Coverage Δ
unittests 63.57% <60.34%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Replace single-letter variable names with descriptive names.
@jhlegarreta
jhlegarreta force-pushed the sty/prefer-f-strings branch from 812e038 to a6ff4b9 Compare August 11, 2026 07:40
@arokem
arokem merged commit 51efc18 into tee-ar-ex:master Aug 11, 2026
15 of 16 checks passed
@jhlegarreta
jhlegarreta deleted the sty/prefer-f-strings branch August 11, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants