ci: require a changeset on PRs to main (and backfill the runtime-rule note) - #53
Merged
Conversation
Add a self-contained workflow that fails a PR to main which adds no .changeset/<name>.md, so a missed changeset (as happened for the runtime-rule-execution stack) is caught in CI. A PR that legitimately needs no release note can carry a 'skip-changeset' label; the job always runs and reports a status, so it's safe to mark as a required check.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens Changesets governance for the repo by (1) backfilling a missing release note for the runtime-rule work and (2) adding a CI workflow that enforces the presence of a new changeset on PRs targeting main, with an explicit label-based escape hatch.
Changes:
- Add a
Require ChangesetGitHub Actions workflow that fails PRs tomainwhen no new.changeset/*.mdfile is added, unless theskip-changesetlabel is present. - Add a minor changeset describing the previously-landed server-owned reconciliation + runtime rule execution work to ensure it appears in the changelog and drives the intended version bump.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/require-changeset.yml |
Adds a PR-to-main guard that requires a newly added changeset file, with a skip-changeset label escape hatch while always reporting a status. |
.changeset/runtime-rule-execution.md |
Backfills the missing minor release note for runtime rule execution and reconciliation so the release bump/changelog reflect the shipped capability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changeset-governance fixes prompted by the runtime-rule work landing without a changeset.
1. Backfill the missed release note
#47/#49/#50(server-owned reconciliation + the runtime-rule harness) merged with no changeset, so the feature wouldn't appear in the changelog or drive a bump. Adds a minor changeset describing it. Combined with the version-header changeset in #52, this lands as0.10.0— which is exactly the CLI version the service gates runtime-rule delivery on.2. Require a changeset going forward
New
require-changeset.yml: a PR tomainthat adds no.changeset/<name>.mdfails, so a missed changeset is caught in CI (self-contained bash check, like the OpenSpec archive check — no install step).skip-changesetlabel for PRs that legitimately ship no release note (docs / CI / chore). The job always runs and reports a status (the label is checked inside the step, not via a job-levelif), so it's safe to add as a required status check without blocking merges on a skipped job.Notes for reviewers
skip-changesetor exclude the bot.Require a changesetas a required check in branch protection once this merges.