Skip to content

Conversation

@tomchon
Copy link
Contributor

@tomchon tomchon commented Jan 22, 2026

Copilot AI review requested due to automatic review settings January 22, 2026 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the GITHUB_RUN_ATTEMPT variable to test runners and workflows to improve tracking of workflow re-runs. The change allows distinguishing between different attempts of the same workflow run, which is useful for debugging and log management.

Changes:

  • Added GITHUB_RUN_ATTEMPT environment variable to workflow files
  • Updated test runner script to incorporate run attempt in log directory naming
  • Modified test execution commands to include run_attempt in build identifiers and paths

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/run-tests-on-linux.yml Added GITHUB_RUN_ATTEMPT to environment variables and updated test execution paths to include run attempt
.github/workflows/new-framework-test.yml Added GITHUB_RUN_ATTEMPT to prepare_test_env.py environment variables
.github/scripts/test_runner.py Added run_attempt variable extraction, created timestamped log directory names, and updated all test commands to use run_attempt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@feici02 feici02 merged commit 29e8034 into main Jan 23, 2026
@feici02 feici02 deleted the enh/add-run-attemp branch January 23, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants