Skip to content

Match func_ov063_021162c8 byte-identical (mwccarm 1.2/sp2p3)#666

Closed
lunavyqo wants to merge 1 commit into
tangosdev:mainfrom
lunavyqo:match/batch2-ov063-021162c8
Closed

Match func_ov063_021162c8 byte-identical (mwccarm 1.2/sp2p3)#666
lunavyqo wants to merge 1 commit into
tangosdev:mainfrom
lunavyqo:match/batch2-ov063-021162c8

Conversation

@lunavyqo

Copy link
Copy Markdown
Contributor

Summary

  • Matched func_ov063_021162c8 @ ov063:0x021162c8 (size 0x108) byte-identical with mwccarm 1.2/sp2p3.
  • Key fix: long-long u64-launder on the *(u16*)(self+0x5d4) &= ~2 site so mwccarm emits the ROM's pool materialization (ldr 0x5d4 + add + ldrh/bic/strh) instead of add #0x500 + ldrh #0xd4.
  • Also banked an improved near-miss for func_ov002_020d8944 (div 15→10): correct p,sum,asr stack layout with Vector3-by-value NewSimple; residual is LDM vs individual loads for the particle call setup.

Verify

python tools/match.py --c src/func_ov063_021162c8.cpp --func func_ov063_021162c8 --addr 0x21162c8 --size 0x108 --version 1.2/sp2p3 --module ov063

Reports MATCH.

Note

Claims API key from the prompt was expired/revoked; coordinated via CLAIMS.md only.

Replace NONMATCHING draft with verified match (long-long u64-launder on
0x5d4 bic). Also bank improved near-miss for func_ov002_020d8944 (div 15→10).
@github-actions

Copy link
Copy Markdown
Contributor

✅ PR link validation — Passed

noverify: no src/.c|.cpp changes in this PR

Each changed src/*.c|*.cpp is compiled and its relocated bytes compared to the binary data on a private build box. Passing requires every changed file to reproduce the ROM byte-for-byte with correct relocation targets — this catches WRONG-DEST relocations and non-reproducing near-misses that ledger-scoped linkcheck skips.

tangosdev pushed a commit that referenced this pull request Jul 24, 2026
…arm 1.2/sp2p3)

Combined landing of PRs #663-666 (fork). Matches re-verified byte-identical:
  func_ov002_020aefb8 (#663), func_ov007_020b2bd4 (#664),
  func_ov006_020cc8c8 + func_ov062_02119af0 (#665),
  func_ov063_021162c8 (#666, .c -> .cpp rename).
Plus two tip improvements: func_ov075_02117d80 5->4, func_ov002_020d8944 15->10.
The five now-matched functions' near-miss entries were pruned.

Provenance: ai model=grok-4.5 reasoning=high harness=grok-build
@tangosdev

Copy link
Copy Markdown
Owner

Match landed on main as c31b271 with your authorship, combined with #663-666. All re-verified byte-identical; the now-matched functions' near-miss entries were pruned and two tip improvements (func_ov075_02117d80 5→4, func_ov002_020d8944 15→10) banked.

@tangosdev tangosdev closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants