Skip to content

Match 10 functions byte-identical (mwccarm 1.2/sp2p3)#662

Closed
andrewboudreau wants to merge 2 commits into
tangosdev:mainfrom
andrewboudreau:match-batch9-freshband
Closed

Match 10 functions byte-identical (mwccarm 1.2/sp2p3)#662
andrewboudreau wants to merge 2 commits into
tangosdev:mainfrom
andrewboudreau:match-batch9-freshband

Conversation

@andrewboudreau

Copy link
Copy Markdown
Collaborator

Matches ten functions across arm9 and overlays using source-only C/C++.

Local verification: all ten pass tools/linkcheck.py with VERIFIED, empty diffs, and blind: 0.

andrewboudreau and others added 2 commits July 23, 2026 14:05
6 via Opus structural pass + 4 via Fable refine escalation. All linkcheck VERIFIED.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XzF9T9FdeAbwq1GBg55oVB
@andrewboudreau
andrewboudreau marked this pull request as ready for review July 24, 2026 00:59
@github-actions

Copy link
Copy Markdown
Contributor

✅ PR link validation — Passed

10 changed src file(s) compile to the ROM byte-for-byte with correct relocations

Per-file link-check detail

All 10 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.

File Symbol Result Slots checked
src/_ZN6Cannon13InitResourcesEv.cpp _ZN6Cannon13InitResourcesEv 🔶 unresolved (symbol not in config/ledger) 0
src/_ZN9DorrieCap8BehaviorEv.cpp _ZN9DorrieCap8BehaviorEv 🔶 unresolved (symbol not in config/ledger) 0
src/func_02042254.c func_02042254 ✅ verified 1
src/func_ov002_020c19d0.cpp func_ov002_020c19d0 ✅ verified 1
src/func_ov006_020eb1e0.c func_ov006_020eb1e0 ✅ verified 1
src/func_ov060_02118728.c func_ov060_02118728 ✅ verified 1
src/func_ov071_02120028.c func_ov071_02120028 ✅ verified 1
src/func_ov085_0212d9b8.c func_ov085_0212d9b8 ✅ verified 1
src/func_ov090_02131c48.c func_ov090_02131c48 ✅ verified 1
src/func_ov091_02133098.cpp func_ov091_02133098 ✅ verified 1

Each changed src/*.c|*.cpp is compiled and its relocated bytes compared to the binary data on a private build box. Passing requires every changed file to reproduce the ROM byte-for-byte with correct relocation targets — this catches WRONG-DEST relocations and non-reproducing near-misses that ledger-scoped linkcheck skips.

@andrewboudreau
andrewboudreau marked this pull request as draft July 24, 2026 01:00
@andrewboudreau

Copy link
Copy Markdown
Collaborator Author

Closing as redundant: these exact 10 matches already merged in #646 (2026-07-23). Verified origin/main contains all 10 with correct extensions and no NONMATCHING headers; this branch's content is byte-identical to main. The displayed delete/add churn is only because the merge-base predates #646.

@andrewboudreau
andrewboudreau deleted the match-batch9-freshband branch July 24, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant