Match 2 functions byte-identical (mwccarm 1.2/sp2p3)#661
Merged
tangosdev merged 1 commit intoJul 24, 2026
Conversation
- func_ov002_020f1468 @ 0x020f1468 (size 0x110): direct mid-block stores keep p out of the y/base schedule; set_fa rematerializes c+0x300; u64-mask multiply path; linkcheck VERIFIED - func_ov006_02124fd8 @ 0x02124fd8 (size 0x10c): early count<=0 skip, do-while reloads count, predicated if(fp<2) return, u64-mask 0x51b8++; linkcheck VERIFIED Author: lunavyqo. Attempt tree + provenance stamped (batch size 2).
Contributor
✅ PR link validation — Passed2 changed src file(s) compile to the ROM byte-for-byte with correct relocations Per-file link-check detailAll 2 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.
Each changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Byte-identical matches (mwccarm 1.2/sp2p3), both
match.py --strict-relocs+linkcheckVERIFIED.func_ov002_020f14680x020f14680x110(272)func_ov006_02124fd80x02124fd80x10c(268)How
0xff/zero branch logic. ROM sets0xfawhen val is0or0xff, else multiplies by 10 via u64-maskc+0x32a. Matching mid-block coloring required not keeping a livep = c+0x300across the y-store; direct*(c+0x32a)stores soycolorsr1and base colorsr0, withset_farematerializingadd r0,r4,#0x300.p/qand used a single predicated>=2tail. ROM skips setup whencount<=0, uses do-while that reloads count each iteration, andif (fp < 2) returnfor the predicated early epilogue; u64-mask materializesc+0x51b8for the increment.Provenance
lunavyqoconfig/match_attempts.jsonl; HOW stamped inconfig/match_provenance.jsonlTest plan
python tools/match.py --c src/func_ov002_020f1468.c --func func_ov002_020f1468 --addr 0x20f1468 --size 0x110 --version 1.2/sp2p3 --module ov002 --strict-relocs→ MATCHpython tools/match.py --c src/func_ov006_02124fd8.c --func func_ov006_02124fd8 --addr 0x2124fd8 --size 0x10c --version 1.2/sp2p3 --module ov006 --strict-relocs→ MATCHpython tools/linkcheck.pyfor both → VERIFIEDvalidategreen