Draft
Conversation
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I4bf750ea2de19b720cd9525852a5268f6a6a6964
The transport implementation is secondary, now in an especially meaningful sense given that transports communicate over PeerIds, while derp uses NodePublicKeys. This rename aligns with separation of the client into the core non-transport functionality, and a transport wrapper that handles translating to and from PeerId (forthcoming in a future commit). Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: If5dd9a39d4e1299fe999f8457e38e94a6a6a6964
The baseline derp client doesn't need to know about translating NodeKeys to transport `PeerId`s, that's a higher level concern now provided by `ts_derp::Transport`, which wraps the underlying client (abstracted behind `NodekeyTransport`) with a `PeerLookup` in order to provide `UnderlayTransport`. This keeps the examples and other functionality dependent on bare derp working without needing to bring in a dummy peer id lookup layer. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ib965f787e92880ac3d74c364760acc546a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip, still validating