refactor: Simplify union message field parsing and fix incell list field properties#388
Open
refactor: Simplify union message field parsing and fix incell list field properties#388
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 74.05% 74.13% +0.07%
==========================================
Files 87 87
Lines 8819 8798 -21
==========================================
- Hits 6531 6522 -9
+ Misses 1718 1710 -8
+ Partials 570 566 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the union message field parsing logic and fixes issues with incell list field properties. The changes simplify the code structure and improve maintainability.
Changes Made
Core Refactoring
parseIncellListfunction: Removed the separateparseListElemsfunction and merged its logic directly intoparseIncellListparseUnionMessageField: Simplified the union field parsing logic for better readabilityKey Files Modified
internal/confgen/parser.go- Major refactoring of incell list and union message field parsinginternal/confgen/table_parser.go- Minor adjustments to maintain consistencyinternal/protogen/files - Corresponding updates in protogen packageTechnical Details
parseIncellListnow returns onlyerrorinstead of(bool, error)Testing
This refactoring makes the codebase more maintainable and easier to understand while preserving all existing functionality.