Skip to content

feat: add AWS Partner Revenue Measurement tag to all modules - #118

Open
ivanbesinovic-sysdig wants to merge 2 commits into
mainfrom
feat-aws-partner-revenue-tag
Open

ivanbesinovic-sysdig wants to merge 2 commits into
mainfrom
feat-aws-partner-revenue-tag

Conversation

@ivanbesinovic-sysdig

Copy link
Copy Markdown
Contributor

Adds the AWS Partner Revenue Measurement tag (aws-apn-id-900918371795 = pc:60xgt35ue7dm4pb1j44e9emhc) to the resources every module creates, merged on top of tags. It can be turned off with enable_aws_partner_tag = false and is skipped outside the commercial aws partition.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The role’s tag lifecycle exclusion prevents existing deployments from receiving the partner tag and prevents its removal when users opt out.

1 open issue
What changed in this PR

Adds AWS Partner Revenue Measurement tagging across the Terraform modules to attribute resource spend to Sysdig.

Changes:

  • Adds a default-enabled enable_aws_partner_tag input and commercial-partition checks.
  • Applies the partner tag to directly managed resources and CloudFormation StackSets.
  • Documents the tag’s purpose and per-module opt-out.
File Description
README.md Explains attribution tagging and opt-out behavior.
modules/​vm-workload-scanning/​variables.tf Adds the tagging toggle.
modules/​vm-workload-scanning/​tags.tf Defines partition-aware tag merging.
modules/​vm-workload-scanning/​README.md Documents the tagging toggle.
modules/​vm-workload-scanning/​organizational.tf Applies merged tags to the StackSet.
modules/​vm-workload-scanning/​main.tf Applies merged tags to IAM resources.
modules/​response-actions/​variables.tf Adds the tagging toggle.
modules/​response-actions/​tags.tf Defines partition-aware tag merging.
modules/​response-actions/​organizational.tf Tags the delegate-role StackSet.
modules/​response-actions/​main.tf Adds partner tags to roles and the Lambda StackSet.
modules/​onboarding/​variables.tf Adds the tagging toggle.
modules/​onboarding/​tags.tf Defines partition-aware tag merging.
modules/​onboarding/​README.md Documents the tagging toggle.
modules/​onboarding/​organizational.tf Applies merged tags to the StackSet.
modules/​onboarding/​main.tf Uses merged tags for the onboarding role.
modules/​integrations/​event-bridge/​variables.tf Adds the tagging toggle.
modules/​integrations/​event-bridge/​tags.tf Defines partition-aware tag merging.
modules/​integrations/​event-bridge/​README.md Documents the tagging toggle.
modules/​integrations/​event-bridge/​organizational.tf Applies merged tags to organizational StackSets.
modules/​integrations/​event-bridge/​main.tf Applies merged tags to roles and the StackSet.
modules/​integrations/​cross-account-event-bridge/​variables.tf Adds the tagging toggle.
modules/​integrations/​cross-account-event-bridge/​tags.tf Defines partition-aware tag merging.
modules/​integrations/​cross-account-event-bridge/​README.md Documents the tagging toggle.
modules/​integrations/​cross-account-event-bridge/​organizational.tf Applies merged tags to organizational StackSets.
modules/​integrations/​cross-account-event-bridge/​main.tf Applies merged tags to roles and the primary-account StackSet.
modules/​integrations/​cloud-logs/​variables.tf Adds the tagging toggle.
modules/​integrations/​cloud-logs/​tags.tf Defines partition-aware tag merging.
modules/​integrations/​cloud-logs/​README.md Documents the tagging toggle.
modules/​integrations/​cloud-logs/​main.tf Applies merged tags to the role, SNS topic, and StackSet.
modules/​config-posture/​variables.tf Adds the tagging toggle.
modules/​config-posture/​tags.tf Defines partition-aware tag merging.
modules/​config-posture/​README.md Documents the tagging toggle.
modules/​config-posture/​organizational.tf Applies merged tags to the StackSet.
modules/​config-posture/​main.tf Applies merged tags to the posture role.
modules/​agentless-scanning/​variables.tf Adds the tagging toggle.
modules/​agentless-scanning/​tags.tf Defines partition-aware tag merging.
modules/​agentless-scanning/​README.md Documents the tagging toggle.
modules/​agentless-scanning/​organizational.tf Applies merged tags to the organizational StackSet.
modules/​agentless-scanning/​main.tf Applies merged tags to roles and the account StackSet.

Review effort: Balanced

Comment thread modules/onboarding/main.tf Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review has no outstanding findings requiring changes to the AWS partner-tagging update.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants