Repository navigation
feat: add AWS Partner Revenue Measurement tag to all modules - #118
Open
ivanbesinovic-sysdig wants to merge 2 commits into
Open
ivanbesinovic-sysdig wants to merge 2 commits into
ivanbesinovic-sysdig wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The role’s tag lifecycle exclusion prevents existing deployments from receiving the partner tag and prevents its removal when users opt out.
1 open issue
What changed in this PR
Adds AWS Partner Revenue Measurement tagging across the Terraform modules to attribute resource spend to Sysdig.
Changes:
- Adds a default-enabled
enable_aws_partner_taginput and commercial-partition checks. - Applies the partner tag to directly managed resources and CloudFormation StackSets.
- Documents the tag’s purpose and per-module opt-out.
| File | Description |
|---|---|
| README.md | Explains attribution tagging and opt-out behavior. |
| modules/vm-workload-scanning/variables.tf | Adds the tagging toggle. |
| modules/vm-workload-scanning/tags.tf | Defines partition-aware tag merging. |
| modules/vm-workload-scanning/README.md | Documents the tagging toggle. |
| modules/vm-workload-scanning/organizational.tf | Applies merged tags to the StackSet. |
| modules/vm-workload-scanning/main.tf | Applies merged tags to IAM resources. |
| modules/response-actions/variables.tf | Adds the tagging toggle. |
| modules/response-actions/tags.tf | Defines partition-aware tag merging. |
| modules/response-actions/organizational.tf | Tags the delegate-role StackSet. |
| modules/response-actions/main.tf | Adds partner tags to roles and the Lambda StackSet. |
| modules/onboarding/variables.tf | Adds the tagging toggle. |
| modules/onboarding/tags.tf | Defines partition-aware tag merging. |
| modules/onboarding/README.md | Documents the tagging toggle. |
| modules/onboarding/organizational.tf | Applies merged tags to the StackSet. |
| modules/onboarding/main.tf | Uses merged tags for the onboarding role. |
| modules/integrations/event-bridge/variables.tf | Adds the tagging toggle. |
| modules/integrations/event-bridge/tags.tf | Defines partition-aware tag merging. |
| modules/integrations/event-bridge/README.md | Documents the tagging toggle. |
| modules/integrations/event-bridge/organizational.tf | Applies merged tags to organizational StackSets. |
| modules/integrations/event-bridge/main.tf | Applies merged tags to roles and the StackSet. |
| modules/integrations/cross-account-event-bridge/variables.tf | Adds the tagging toggle. |
| modules/integrations/cross-account-event-bridge/tags.tf | Defines partition-aware tag merging. |
| modules/integrations/cross-account-event-bridge/README.md | Documents the tagging toggle. |
| modules/integrations/cross-account-event-bridge/organizational.tf | Applies merged tags to organizational StackSets. |
| modules/integrations/cross-account-event-bridge/main.tf | Applies merged tags to roles and the primary-account StackSet. |
| modules/integrations/cloud-logs/variables.tf | Adds the tagging toggle. |
| modules/integrations/cloud-logs/tags.tf | Defines partition-aware tag merging. |
| modules/integrations/cloud-logs/README.md | Documents the tagging toggle. |
| modules/integrations/cloud-logs/main.tf | Applies merged tags to the role, SNS topic, and StackSet. |
| modules/config-posture/variables.tf | Adds the tagging toggle. |
| modules/config-posture/tags.tf | Defines partition-aware tag merging. |
| modules/config-posture/README.md | Documents the tagging toggle. |
| modules/config-posture/organizational.tf | Applies merged tags to the StackSet. |
| modules/config-posture/main.tf | Applies merged tags to the posture role. |
| modules/agentless-scanning/variables.tf | Adds the tagging toggle. |
| modules/agentless-scanning/tags.tf | Defines partition-aware tag merging. |
| modules/agentless-scanning/README.md | Documents the tagging toggle. |
| modules/agentless-scanning/organizational.tf | Applies merged tags to the organizational StackSet. |
| modules/agentless-scanning/main.tf | Applies merged tags to roles and the account StackSet. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds the AWS Partner Revenue Measurement tag (
aws-apn-id-900918371795=pc:60xgt35ue7dm4pb1j44e9emhc) to the resources every module creates, merged on top oftags. It can be turned off withenable_aws_partner_tag = falseand is skipped outside the commercialawspartition.