Repository navigation
response-actions: PackageDownloaderLogGroup deletion policy leaving unwanted resources - #113
Merged
fcracker79 merged 1 commit intoJul 16, 2026
Conversation
…loaderLogGroup PackageDownloaderLogGroup was the only one of the eight Lambda log groups with DeletionPolicy: Retain. On offboarding, the log group survived the stackset deletion, and a subsequent re-onboarding failed because the log group already existed. Removing the policy aligns it with the other seven log groups (CloudFormation default: Delete) and fixes re-onboarding. Fixes ESC-7457 Closes #112 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ivanbesinovic-sysdig
approved these changes
Jul 16, 2026
fcracker79
deleted the
fix/esc-7457-package-downloader-log-group-deletion-policy
branch
July 16, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When using
modules/response-actions,PackageDownloaderLogGroupis created in every stackset withDeletionPolicy: Retain. It was the only one of the eight Lambda log groups configured this way — the other seven use CloudFormation's default (Delete).If an account/region is offboarded and later onboarded again, the retained log group (
/aws/lambda/${ResourceName}-package-downloader) survives the stackset deletion, so re-onboarding fails because the resource already exists.Fix
Remove
DeletionPolicy: RetainfromPackageDownloaderLogGroupintemplates/lambda-stackset.tpl, aligning it with the other log groups so it is deleted on offboarding and can be recreated on re-onboarding.