fix: qr code decoding error message #559
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the error messages displayed when QR code decoding fails to align with iOS implementation. The change improves consistency across platforms by using the same generic error messages for all QR code decode failures.
- Updated error message strings to use more generic wording matching iOS
- Added
isQrCodeparameter tohandleScanfunction to distinguish QR code scans from pasted invoices
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ovitrif
force-pushed
the
feat/nav3
branch
3 times, most recently
from
e57eef3 to
1eb159f
Compare
# Conflicts: # app/src/main/java/to/bitkit/ui/ContentView.kt # app/src/main/java/to/bitkit/ui/MainActivity.kt # app/src/main/java/to/bitkit/ui/components/AuthCheckScreen.kt # app/src/main/java/to/bitkit/ui/components/DrawerMenu.kt # app/src/main/java/to/bitkit/ui/components/SheetHost.kt # app/src/main/java/to/bitkit/ui/nav/DeepLinks.kt # app/src/main/java/to/bitkit/ui/nav/Navigator.kt # app/src/main/java/to/bitkit/ui/nav/Routes.kt # app/src/main/java/to/bitkit/ui/nav/SheetSceneStrategy.kt # app/src/main/java/to/bitkit/ui/nav/entries/HomeEntries.kt # app/src/main/java/to/bitkit/ui/nav/entries/OnboardingEntries.kt # app/src/main/java/to/bitkit/ui/nav/entries/SettingsEntries.kt # app/src/main/java/to/bitkit/ui/nav/entries/SheetEntries.kt # app/src/main/java/to/bitkit/ui/nav/entries/TransferEntries.kt # app/src/main/java/to/bitkit/ui/nav/entries/WidgetEntries.kt # app/src/main/java/to/bitkit/ui/screens/settings/DevSettingsScreen.kt # app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt # app/src/main/java/to/bitkit/ui/screens/wallets/activity/ActivityDetailScreen.kt # app/src/main/java/to/bitkit/ui/screens/wallets/send/AddTagScreen.kt # app/src/main/java/to/bitkit/ui/screens/wallets/send/SendAddressScreen.kt # app/src/main/java/to/bitkit/ui/screens/wallets/send/SendRecipientScreen.kt # app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt # app/src/main/java/to/bitkit/ui/settings/BackupSettingsScreen.kt # app/src/main/java/to/bitkit/ui/settings/LogsScreen.kt # app/src/main/java/to/bitkit/ui/settings/SecuritySettingsScreen.kt # app/src/main/java/to/bitkit/ui/settings/SettingsScreen.kt # app/src/main/java/to/bitkit/ui/settings/appStatus/AppStatusScreen.kt # app/src/main/java/to/bitkit/ui/settings/backups/ResetAndRestoreScreen.kt # app/src/main/java/to/bitkit/ui/settings/backups/ShowMnemonicScreen.kt # app/src/main/java/to/bitkit/ui/settings/general/GeneralSettingsScreen.kt # app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt # app/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionScreen.kt # app/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsScreen.kt # app/src/main/java/to/bitkit/ui/settings/pin/ChangePinConfirmScreen.kt # app/src/main/java/to/bitkit/ui/settings/pin/ChangePinNewScreen.kt # app/src/main/java/to/bitkit/ui/settings/pin/ChangePinResultScreen.kt # app/src/main/java/to/bitkit/ui/settings/pin/ChangePinScreen.kt # app/src/main/java/to/bitkit/ui/settings/support/SupportScreen.kt # app/src/main/java/to/bitkit/ui/settings/transactionSpeed/TransactionSpeedSettingsScreen.kt # app/src/main/java/to/bitkit/ui/sheets/GiftViewModel.kt # app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
Description
This PR updates the QR code decode message, like iOS
OBS: I noticed that iOS uses the same message to all decode cases. It could be used a generic message to when user paste the invoice
Preview
N/A
QA Notes
Read invalid QR code