Skip to content

Perf: Replace ContainsKey + indexer with TryGetValue to eliminate redundant hash lookups #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulAndersonS merged 2 commits into from
May 26, 2026
Merged

Perf: Replace ContainsKey + indexer with TryGetValue to eliminate redundant hash lookups #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4cb1d
Perf: Replace ContainsKey + indexer with TryGetValue
PaulAndersonS May 25, 2026
d32c22c
Perf: Remove unnecessary ToList() copies in Accordion
PaulAndersonS May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maui/src/Accordion/AccordionItemView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ internal bool CanCollapseItemOnSingleAndMultipleExpandMode()
return false;
}

var expandedItems = Accordion.Items.ToList().FindAll(x => x._accordionItemView != null && x._accordionItemView.IsExpanded);
var expandedItems = Accordion.Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsExpanded).ToList();
return (Accordion.ExpandMode == AccordionExpandMode.Single ||
Accordion.ExpandMode == AccordionExpandMode.Multiple) && expandedItems.Count == 1;
}
Expand Down
6 changes: 3 additions & 3 deletions maui/src/Accordion/SfAccordion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ internal void UpdateIsExpandValueBasedOnIndex(int index, bool isExpanded)
/// </summary>
internal void UpdateSelection()
{
var selectedItems = Items.ToList().FindAll(x => x._accordionItemView != null && x._accordionItemView.IsSelected);
var selectedItems = Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsSelected).ToList();
if (selectedItems.Count == 1 && Items[selectedItems[0]._itemIndex] is AccordionItem items && items._accordionItemView is AccordionItemView accordionItem)
{
accordionItem.IsSelected = false;
Expand All @@ -560,7 +560,7 @@ internal void UpdateAccordionItemsBasedOnExpandModes(bool isExpandModeChanged)
return;
}

var expandedItems = Items.ToList().FindAll(x => x._accordionItemView != null && x._accordionItemView.IsExpanded);
var expandedItems = Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsExpanded).ToList();
switch (ExpandMode)
{
case AccordionExpandMode.Single:
Expand Down Expand Up @@ -1575,7 +1575,7 @@ void IKeyboardListener.OnPreviewKeyDown(Syncfusion.Maui.Toolkit.Internals.KeyEve
/// <param name="e">The <see cref="KeyEventArgs"/> containing the event data for the key that was pressed.</param>
void IKeyboardListener.OnKeyDown(KeyEventArgs e)
{
var selectedItem = Items.ToList().FirstOrDefault(x => x._accordionItemView != null && x._accordionItemView.IsSelected);
var selectedItem = Items.FirstOrDefault(x => x._accordionItemView != null && x._accordionItemView.IsSelected);
if (e.Key == KeyboardKey.Down || (e.Key == KeyboardKey.Tab && !e.IsShiftKeyPressed))
{
OnDownKeyPressed(selectedItem);
Expand Down
11 changes: 9 additions & 2 deletions maui/src/Calendar/LoopingPannel/CustomSnapManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,8 +1014,15 @@ void AddChildren()
for (int i = 0; i < ChildCount; i++)
{
List<DateTime> visibleDates = GetVisibleDatesForView(i);
List<DateTime> disableDates = _disabledDatesDictionary.ContainsKey(visibleDates) ? _disabledDatesDictionary[visibleDates] : new List<DateTime>();
List<CalendarIconDetails> specialDates = _specialDatesDictionary.ContainsKey(visibleDates) ? _specialDatesDictionary[visibleDates] : new List<CalendarIconDetails>();
if (!_disabledDatesDictionary.TryGetValue(visibleDates, out List<DateTime>? disableDates))
{
disableDates = new List<DateTime>();
}

if (!_specialDatesDictionary.TryGetValue(visibleDates, out List<CalendarIconDetails>? specialDates))
{
specialDates = new List<CalendarIconDetails>();
}
Comment thread
PaulAndersonS marked this conversation as resolved.
if (_calendarInfo.View == CalendarView.Month)
{
MonthViewLayout monthViewLayout = new MonthViewLayout(_calendarInfo, visibleDates, _calendarInfo.SelectedDate, disableDates, specialDates, i == _currentChildIndex);
Expand Down
14 changes: 2 additions & 12 deletions maui/src/Core/WindowOverlay/WindowOverlay.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,12 +539,7 @@ void UpdateChildPositionAndAlignment(
WindowOverlayHorizontalAlignment horizontalAlignment,
WindowOverlayVerticalAlignment verticalAlignment)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down Expand Up @@ -582,12 +577,7 @@ void UpdateChildPositionAndAlignment(
double x = 0,
double y = 0)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down
14 changes: 2 additions & 12 deletions maui/src/Core/WindowOverlay/WindowOverlay.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,7 @@ void UpdateChildPositionAndAlignment(
WindowOverlayHorizontalAlignment horizontalAlignment,
WindowOverlayVerticalAlignment verticalAlignment)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down Expand Up @@ -332,12 +327,7 @@ void UpdateChildPositionAndAlignment(
double x = 0,
double y = 0)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down
14 changes: 2 additions & 12 deletions maui/src/Core/WindowOverlay/WindowOverlay.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,12 +369,7 @@ void UpdateChildPositionAndAlignment(UIView childView,
WindowOverlayHorizontalAlignment horizontalAlignment,
WindowOverlayVerticalAlignment verticalAlignment)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down Expand Up @@ -413,12 +408,7 @@ void UpdateChildPositionAndAlignment(
double x = 0,
double y = 0)
{
PositionDetails details;
if (_positionDetails.ContainsKey(childView))
{
details = _positionDetails[childView];
}
else
if (!_positionDetails.TryGetValue(childView, out PositionDetails? details))
{
details = new PositionDetails();
_positionDetails.Add(childView, details);
Expand Down