Skip to content

Catching known errors when opening/closing files #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gohar94 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Catching known errors when opening/closing files #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ilock/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@ def __enter__(self):

current_time = call_time = time()
while call_time + self._timeout >= current_time:
self._lockfile = open(self._filepath, 'w')
try:
self._lockfile = open(self._filepath, 'w')
portalocker.lock(self._lockfile, portalocker.constants.LOCK_NB | portalocker.constants.LOCK_EX)
self._enter_count = 1
return self
except portalocker.exceptions.LockException:
pass
except PermissionError:
pass

current_time = time()
check_interval = self._check_interval if self._timeout > self._check_interval else self._timeout
Expand All @@ -56,7 +58,10 @@ def __exit__(self, exc_type, exc_val, exc_tb):

if sys.platform.startswith('linux'):
# In Linux you can delete a locked file
os.unlink(self._filepath)
try:
os.unlink(self._filepath)
except FileNotFoundError:
Copy link
Copy Markdown

@yagelsyf yagelsyf Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change that I want to add too.
In rare cases that happen from time to time, its happen.

Copy link
Copy Markdown

@Cologler Cologler Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained why this wouldn't work in #7 (comment).

pass

self._lockfile.close()

Expand Down