Closed
Conversation
format_py_dir doesn't work because it doesn't use the ruff config. Example failure: https://github.com/symforce-org/symforce/actions/runs/20531137563/job/58982549124?pr=450 Here we have a line between 80 and 100 chars, so with the correct config, it stays on the same line. If you format it with an 80-char config and then a 100-char config though, it's broken across lines and the trailing comma is added, so formatting with 100 chars doesn't put it back on one line. And it has to be a list for the trailing comma thing to happen, that's why this is pretty rare. Topic: sf-ruff-wheel-types
Member
Author
|
Reviews in this chain: |
Member
Author
asa
pushed a commit
to asa/symforce
that referenced
this pull request
Jan 23, 2026
Fix ruff format of types from wheel format_py_dir doesn't work because it doesn't use the ruff config. Example failure: https://github.com/symforce-org/symforce/actions/runs/20531137563/job/58982549124?pr=450 Here we have a line between 80 and 100 chars, so with the correct config, it stays on the same line. If you format it with an 80-char config and then a 100-char config though, it's broken across lines and the trailing comma is added, so formatting with 100 chars doesn't put it back on one line. And it has to be a list for the trailing comma thing to happen, that's why this is pretty rare. Topic: sf-ruff-wheel-types Closes symforce-org/symforce#452 GitOrigin-RevId: 6b98c6c7f3a5ffc69c9ec471ac1a73de4ca01e7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_py_dir doesn't work because it doesn't use the ruff config.
Example failure: https://github.com/symforce-org/symforce/actions/runs/20531137563/job/58982549124?pr=450
Here we have a line between 80 and 100 chars, so with the correct
config, it stays on the same line. If you format it with an 80-char
config and then a 100-char config though, it's broken across lines and
the trailing comma is added, so formatting with 100 chars doesn't put it
back on one line. And it has to be a list for the trailing comma thing
to happen, that's why this is pretty rare.
Topic: sf-ruff-wheel-types