[Toolkit][Shadcn] Add DropdownMenu component #3232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daFish
force-pushed
the
feat/toolkit-dropdown-component
branch
from
960d31f to
e5f1901
Compare
carsonbot
added
Bug
Contributor
Author
|
I have also added support for dropdown-menu in button group. /cc @bernard-ng |
daFish
force-pushed
the
feat/toolkit-dropdown-component
branch
2 times, most recently
from
7ad8366 to
a18aa60
Compare
Member
|
Hi! I started to look at your work, and thanks you so much for that! However, I find there is too much logic in the
Thanks! |
Kocal
requested changes
Dec 16, 2025
src/Toolkit/kits/shadcn/dropdown-menu/templates/components/DropdownMenu/Content.html.twig
Outdated
Show resolved
Hide resolved
carsonbot
added
Status: Needs Work
Contributor
Author
|
@Kocal How to handle custom styles? Should I import them in the controller or is this something to be handled in user land? |
daFish
force-pushed
the
feat/toolkit-dropdown-component
branch
from
a18aa60 to
18181ba
Compare
carsonbot
added
Status: Needs Review
daFish
force-pushed
the
feat/toolkit-dropdown-component
branch
from
18181ba to
2c87864
Compare
daFish
commented
Dec 16, 2025
daFish
force-pushed
the
feat/toolkit-dropdown-component
branch
from
2c87864 to
03e3b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DropdownMenu as a component with support for checkboxes, radio group, and dialog. It utilizes the already available components like Kbd and Dialog. The Button Group component is also updated to use the new component.
ref: https://ui.shadcn.com/docs/components/dropdown-menu