Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 626ada8b58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (targetSessionUuid && | ||
| sessionStore.lastRequestedSessionUuid !== targetSessionUuid && | ||
| sessionStore.lastRequestedSessionUuid !== null) { | ||
| console.log('Navigation target differs from last requested session, skipping to prevent loop') | ||
| sessionStore.lastRequestedSessionUuid === targetSessionUuid) { | ||
| console.log('Navigation target matches last requested session, skipping to prevent loop') |
There was a problem hiding this comment.
This condition now returns early when targetSessionUuid equals lastRequestedSessionUuid, but setActiveSession() sets lastRequestedSessionUuid to the same session immediately before calling navigateToWorkspace(). In the normal session-switch flow, this makes navigateToWorkspace() bail out and never call router.push, so the active session state changes while the route stays on the previous chat, breaking session switching/navigation consistency.
Useful? React with 👍 / 👎.
1 participant
No description provided.