Revert "Revert "Minimally integrate per-page HTML content into each "index.html" file"" #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index.ht…" This reverts commit db163a1.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
The cross-repo build for this passes for the Windows CI, so we're good to merge this again. 
|
snprajwal
approved these changes
Dec 12, 2025
d-ronnqvist
deleted the
revert-1392-revert-1383-output-html-integrate-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1392
Now that swiftlang/swift#85995 is merged, and DocC once again included in the Windows build, the changes in #1383 shouldn't have any impact on the Windows tests anymore. I'm verifying that with a cross-repo test (in swiftlang/swift#84510 (comment)) but it takes few hours to run.
Like I said in my original review of #818 and my later PR to revert it:
I really don't think that any integration that can cause blocking CI failures for the toolchain should be merged again until after DocC has a Windows CI. I feel that the only correct order to do add DocC to the Windows build is:
If we keep trying to skip step 2 I think it's better to undo step 1 by merging #1353 so that step 1 and 2 can be added back together before step 3.