Identify the root module of the navigator out of nested modules #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to use `landData` and `data` when we are referring to `modules` in the navigator instead. This change replace `landData` and `data` with `modules`. It also replace `node` with `module`. This change will help us to identify the modules that we need to flat in future commits.
In some cases, our navigator can have nested modules within the top level modules. We want to extract all of them to be able to identify which module we want to use. This change introduces a recursively function that flatten a nested module structure into a single array. So we can identify which it's the top level module.
To be consistent with previous changes, we want to rename this function.
Now that we aren't always extracting the top level modules, but the root module for the navigator. We want to replace the name of topLevelModule with rootModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #163125305, if applicable:
Summary
In some cases, our navigator can have nested modules within the top level modules. We want to extract all of them to be able to identify which it's the root module that the navigator should use.
This change introduces a recursively function that flatten a nested module structure into a single array.
It's confusing to use
landDataanddatawhen we are referring tomodulesin the navigator. So this PR also renames:landData->modulesdata->modulesnode->moduleDependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded