Clean up multi_handles on the same thread
#5304
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
URLSessionelusively crashes due to a race condition in OpenSSL <1.1.0 when callingcurl_multi_cleanupconcurrently in different threads.Partially resolves #3813
Modifications:
_MultiHandle.deinitto asynchronously queuecurl_multi_cleanupcalls in_MultiHandle.queue.Result:
Saves OpenSSL from cleaning up concurrently in different threads, avoiding the crash.
Testing:
Passing existing tests is sufficient. However, without this patch, the code snippet below crashes about once in 20 runs on Amazon Linux 2