Move many Apple platforms build rules under the darwin domain #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
kulpreetchilana,
matthewseaman,
mhrawdon and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
|
@swift-ci test |
| self.appShortcutStringsMetadataCompilerSpec = workspaceContext.core.specRegistry.getSpec("com.apple.compilers.appshortcutstringsmetadata", domain: domain) as! AppShortcutStringsMetadataCompilerSpec | ||
| self.appleScriptCompilerSpec = workspaceContext.core.specRegistry.getSpec("com.apple.compilers.osacompile", domain: domain) as! CommandLineToolSpec | ||
| self.appShortcutStringsMetadataCompilerSpec = workspaceContext.core.specRegistry.getSpec("com.apple.compilers.appshortcutstringsmetadata", domain: domain) as? AppShortcutStringsMetadataCompilerSpec | ||
| self.appleScriptCompilerSpec = workspaceContext.core.specRegistry.getSpec("com.apple.compilers.osacompile", domain: domain) as? CommandLineToolSpec |
Collaborator
There was a problem hiding this comment.
Are you sure as? CommandLineToolSpec is correct? Should it be as CommandLineToolSpec?? I forgot how the generics are set up here, but just worth double checking.
e.g. if this was an instance of OtherKindOfSpec I'd expect this to fail rather than return nil.
Collaborator
Author
There was a problem hiding this comment.
I ended up just reworking getSpec to take an explicit type parameter so we're not relying on coercions and casting behavior here
Collaborator
Author
|
@swift-ci test |
neonichu
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we don't attempt to apply them when targeting a non-Apple platform.
Closes swiftlang/swift-package-manager#9423