Skip to content

Plugins: install DLL to bin, import library to lib #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
compnerd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Plugins: install DLL to bin, import library to lib #2367

compnerd wants to merge 1 commit into from

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Nov 23, 2025

Adjust the install rules to account for the different installation expectations on Windows. DLL files are installed into the bin and import libraries are to be installed in lib.

@compnerd
Plugins: install DLL to bin, import library to lib
034f238 
Adjust the install rules to account for the different installation
expectations on Windows. DLL files are installed into the `bin` and
import libraries are to be installed in `lib`.
@compnerd
Copy link
Member Author

compnerd commented Nov 23, 2025

@swift-ci please test

@compnerd compnerd mentioned this pull request Nov 23, 2025
Draft
@ahoppen
Copy link
Member

ahoppen commented Nov 24, 2025

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

@compnerd
Copy link
Member Author

compnerd commented Nov 24, 2025 •
edited
Loading

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

Well, all the DLLs are meant to be in bin. It really doesn't matter how you use them. That said, it seems that the installer still put them into bin, just did so in the installer.

This PR is paired with swiftlang/swift-installer-scripts#485 and you will see that only the source is changed, not the destination.

ahoppen
ahoppen approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Looks good to me 👍🏽

@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2025

@swift-ci please test Windows platform

2 similar comments
@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2025

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Dec 12, 2025

@swift-ci please test Windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@compnerd @ahoppen