[lldb] Allow LLDBMemoryReader to provide symbols outside refl. sections #11954
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
Author
There are swift metadata symbols outside the "__swift_" sections. For example, swift context descriptors live in the "const" sections. Allow LLDBMemoryReader::resolvePointerAsSymbol to return any symbol that it finds. rdar://165950673
Author
1 similar comment
Author
Address::CalculateSymbolContextSymbol() finds the wrong symbol on Linux when debugging swift application because symbols have an actual size (as opposed to macOS, where they have size 0). This is either an LLDB or a swift compiler bug. For now, disable this optimization on Linux.
augusto2112
force-pushed
the
symbols-outside-refl
branch
from
a70217f to
841e53e
Compare
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are swift metadata symbols outside the "_swift" sections. For example, swift context descriptors live in the "const" sections. Allow LLDBMemoryReader::resolvePointerAsSymbol to return any symbol that it finds.
rdar://165950673