test(es/tsc): Support for tsc multi-file unit tests - #5316
Merged
Merged
Conversation
magic-akari
marked this pull request as ready for review
July 27, 2022 06:55
magic-akari
marked this pull request as draft
July 27, 2022 07:57
magic-akari
marked this pull request as ready for review
July 27, 2022 09:17
magic-akari
commented
Jul 27, 2022
| @@ -0,0 +1,12 @@ | |||
| // @filename: file.tsx | |||
| //! | |||
| //! x Unexpected token `a`. Expected jsx identifier | |||
Member
Author
There was a problem hiding this comment.
Maybe it's better to correct error reporter.
Unexpected token `\u0061`. Expected jsx identifier
| //@Filename: decls.ts | ||
| // Ambient external module with export assignment | ||
| // Ambient external import declaration referencing ambient external module using top level module name | ||
| // Ambient external import declaration referencing ambient external module using top level module name |
| //! 9 | interface Thing { } | ||
| //! 10 | } | ||
| //! 11 | declare module 'react-router' { | ||
| //! 12 | export = ReactRouter; |
Member
Author
There was a problem hiding this comment.
🤔 it's a bug.
We should not handle anything in declare module
swc playground
magic-akari
changed the title
@FileName directives
Donny/강동윤 (kdy1)
approved these changes
Jul 29, 2022
Donny/강동윤 (kdy1)
left a comment
Donny/강동윤 (kdy1)
left a comment
Member
There was a problem hiding this comment.
Thanks!
swc-bump:
- ''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):