fix: use non-inline source maps when only sourceMap is true in tsconfig#1024
Merged
Brooooooklyn merged 1 commit intoswc-project:masterfrom Mar 31, 2026
Merged
Conversation
When tsconfig has sourceMap: true without inlineSourceMap, the sourcemap option was incorrectly set to 'inline' due to operator precedence in the ternary expression. This caused broken line numbers in stack traces (off by the number of type-only lines stripped by SWC). The fix ensures inline source maps are only produced when explicitly requested via inlineSourceMap: true in tsconfig or the SWC_NODE_INLINE_SOURCE_MAP environment variable. Closes swc-project#848 Closes swc-project#861
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tsconfig has sourceMap: true without inlineSourceMap, the sourcemap option was incorrectly set to 'inline' due to operator precedence in the ternary expression. This caused broken line numbers in stack traces (off by the number of type-only lines stripped by SWC).
The fix ensures inline source maps are only produced when explicitly requested via inlineSourceMap: true in tsconfig or the SWC_NODE_INLINE_SOURCE_MAP environment variable.
Closes #848
Closes #861