add additional OpenAPIExtension::decorateOperation overload#3917
Open
fabianvo wants to merge 5 commits intoswagger-api:masterfrom
Open
add additional OpenAPIExtension::decorateOperation overload#3917fabianvo wants to merge 5 commits intoswagger-api:masterfrom
fabianvo wants to merge 5 commits intoswagger-api:masterfrom
Conversation
frantuma
suggested changes
Apr 18, 2021
| extension.decorateOperation(cls, operation, method, chain2); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I would rather use same iterator and invoke in sequence the 2 overloads, is there a reason why two iterations are necessary?
| return openAPI; | ||
| } | ||
|
|
||
| protected void decorateOperation(Class<?> cls, Operation operation, Method method) { |
Contributor
There was a problem hiding this comment.
Would possibly just add javadoc @since 2.1.9
|
|
||
| /** | ||
| * Decorates operation with additional vendor based extensions. | ||
| * |
Contributor
There was a problem hiding this comment.
would add some clarification in javadocs, mentioning that new overload is available @since 2.1.9 and that the two overloads are both invoked in a given order
|
@fabianvo Would be great to have this PR merged. Any chance you have another look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3916
I added a second overload to avoid breaking existing OpenAPIExtension implementations.
Having access to a declaring class allows implementing some resource methods in abstract base classes without needing to override in each subclass just to decorate them with all required annotations.
I included a simple use case in DecoratorExtensionTest.java