fix: too complex type error when using union props type by handling unions in Bindings generic #17348
+185
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unions in binding generic
🦋 Changeset detectedLatest commit: 59e6d4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
that-richan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles union props in
Bindings extendsso that theComponenttype doesn't scream about too complex types when using an union withHTMLAttributesin thePropsgeneric.Not sure at all about the removal of
Omit<Props, '$$slots' | '$$events'>but I was unable to find a reference that would prove to me that $$slots and $$events are even important to Omit there. Removed it because otherwise therendermethod would complain about too complex types and something seemed fishy about that. Also added NoInfer to improve some type checks which started screaming when writing the tests.