feat: add model pricing #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paoloricciuti
left a comment
paoloricciuti
left a comment
There was a problem hiding this comment.
Overall looks good to me, I think the pricing stuff might be simplified a bit (building the map beforehand seems a bit unnecessary but it's also fine)
index.ts
Outdated
Comment on lines
52
to
62
| interface PricingValidationResult { | ||
| enabled: boolean; | ||
| lookups: Map<string, ModelPricingLookup | null>; | ||
| } | ||
|
|
||
| interface SelectOptionsResult { | ||
| models: string[]; | ||
| mcp: string | undefined; | ||
| testingTool: boolean; | ||
| pricing: PricingValidationResult; | ||
| } |
Member
There was a problem hiding this comment.
I guess this is a me thing but I generally strongly prefer to infer types when possible? Do you feel strongly about defining return types?
Collaborator
Author
There was a problem hiding this comment.
I'll check if we can remove some types so they can be inferred, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
TODO