Skip to content

Optimize onboarding chat document creation with Promise.all #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishaanxgupta wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −8
Open

Optimize onboarding chat document creation with Promise.all #822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b40ced
Optimize onboarding chat document creation with Promise.all
ishaanxgupta Apr 2, 2026
6567f3d
Optimize onboarding chat document creation with Promise.all
ishaanxgupta Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions apps/web/components/onboarding/setup/chat-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
const isProcessingRef = useRef(false)
const draftRequestIdRef = useRef(0)

const backendUrl = new URL(process.env.NEXT_PUBLIC_BACKEND_URL!)

Check warning on line 79 in apps/web/components/onboarding/setup/chat-sidebar.tsx

View workflow job for this annotation

GitHub Actions / Quality Checks

lint/style/noNonNullAssertion 

Forbidden non-null assertion.
const agent = useAgent({
agent: "chat-agent",
name: user?.id ?? "anonymous",
Expand Down Expand Up @@ -381,11 +381,9 @@
setIsLoading(true)

try {
const documentIds: string[] = []

for (const draft of draftDocs) {
const promises = draftDocs.map(async (draft) => {
if (draft.kind === "x_research" && xResearchStatus !== "correct") {
continue
return null
}

try {
Expand All @@ -397,13 +395,17 @@
},
})

if (docResponse.data?.id) {
documentIds.push(docResponse.data.id)
}
return docResponse.data?.id
} catch (error) {
console.warn("Error creating document:", error)
return null
}
}
})

const results = await Promise.all(promises)
const documentIds = results.filter(
(id): id is string => id !== null && id !== undefined,
)

if (documentIds.length > 0) {
await pollForMemories(documentIds)
Expand Down
Loading