Repository navigation
Record image resolution strategy failures on the wrapper span - #5323
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a local or remote image resolution strategy returns an error, ResolveReference returns it without marking its own resolve_reference span as failed. Trace consumers can therefore report image resolution as successful despite the failed deploy.
Record the returned strategy error on the wrapper span using the existing tracing.RecordError helper, matching the no-image-found path. This preserves the exception, error status, and cancellation context without changing resolver behavior.
Validation: go test ./internal/build/imgsrc, go vet ./internal/build/imgsrc, and git diff --check passed.
Non-test lines: +1/-0. Test lines: +0/-0.