Repository navigation
Add operation spans for deploy journey stages - #5321
Open
benbjohnson wants to merge 2 commits into
Open
benbjohnson wants to merge 2 commits into
benbjohnson wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy journey analysis currently has to reuse planning or image-preparation spans for logical stages that have no operation span of their own. Add
deployment_configuration,validate_image_inputs,deployment_readiness, andfinalize_deploymentspans so those stages can report their own duration and outcome.Readiness wraps checks per Machine in both the normal and recovery rollout paths. The normal state wait also gains
wait_for_machine_state, matching the recovery path. Finalization contains the terminal release update, statics finalization/cleanup, and DNS checks; nonfatal finalization errors mark this span without changing command success. Existing deployment ordering and returned errors are preserved.Validation: deploy package tests pass with a temporary FLY_CONFIG_DIR; full flyctl binary builds. Tests verify configuration/finalization ancestry, validation error recording, and readiness ancestry in both rollout paths.
Changes: non-test code +141 / -82 lines; test code +96 / -0 lines.