Skip to content

Report Depot builder targets and connection failures - #5319

Merged
tomr-fly merged 4 commits into
masterfrom
tomr/depot-acquisition-target
Oct 23, 2026
Merged

tomr-fly merged 4 commits into
masterfrom
tomr/depot-acquisition-target

Conversation

@tomr-fly

Copy link
Copy Markdown
Contributor

Include the acquired Depot builder target and connection stage in build reports so web can resolve the builder region and group failures. Preserve useful error details and give canceled builds a bounded chance to report.

@tomr-fly tomr-fly self-assigned this Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Resolve the critical finish-context deadline issue and the moderate error-classification and configuration-retry issues before approval.

2 open issues
What changed in this PR

This pull request adds Depot builder routing and connection diagnostics to build reports, including failure details and bounded reporting after cancellation.

Changes:

  • Adds Depot acquisition target, connection stage, and outcome metadata.
  • Adds readiness retries, error preservation, and connection classification.
  • Adds cancellation handling and telemetry tests.
File Summary
internal/​uiex/​builders.go Adds Depot telemetry fields to builder metadata.
internal/​build/​imgsrc/​resolver.go Adds bounded context handling for failed Depot reports.
internal/​build/​imgsrc/​depot.go Records the acquired target and connection stages.
internal/​build/​imgsrc/​depot_test.go Tests acquisition metadata privacy on failure.
internal/​build/​imgsrc/​depot_telemetry_test.go Tests telemetry, retries, cancellation, and failure reporting.
internal/​build/​imgsrc/​depot_connection.go Implements readiness retries and connection error classification.
go.mod Promotes protobuf to a direct dependency for test utilities.

Review effort: Lite

Comment thread internal/build/imgsrc/resolver.go
Comment thread internal/build/imgsrc/depot_connection.go Outdated
@tomr-fly
tomr-fly marked this pull request as ready for review October 23, 2026 22:49
@tomr-fly
tomr-fly merged commit a20ba2e into master Oct 23, 2026
26 checks passed
@tomr-fly
tomr-fly deleted the tomr/depot-acquisition-target branch October 23, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants