Repository navigation
Report Depot builder targets and connection failures - #5319
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the critical finish-context deadline issue and the moderate error-classification and configuration-retry issues before approval.
2 open issues
What changed in this PR
This pull request adds Depot builder routing and connection diagnostics to build reports, including failure details and bounded reporting after cancellation.
Changes:
- Adds Depot acquisition target, connection stage, and outcome metadata.
- Adds readiness retries, error preservation, and connection classification.
- Adds cancellation handling and telemetry tests.
| File | Summary |
|---|---|
internal/uiex/builders.go |
Adds Depot telemetry fields to builder metadata. |
internal/build/imgsrc/resolver.go |
Adds bounded context handling for failed Depot reports. |
internal/build/imgsrc/depot.go |
Records the acquired target and connection stages. |
internal/build/imgsrc/depot_test.go |
Tests acquisition metadata privacy on failure. |
internal/build/imgsrc/depot_telemetry_test.go |
Tests telemetry, retries, cancellation, and failure reporting. |
internal/build/imgsrc/depot_connection.go |
Implements readiness retries and connection error classification. |
go.mod |
Promotes protobuf to a direct dependency for test utilities. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Include the acquired Depot builder target and connection stage in build reports so web can resolve the builder region and group failures. Preserve useful error details and give canceled builds a bounded chance to report.