Repository navigation
Mark deploy traces for complete backend retention - #5318
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the deploy command context with W3C baggage
flyctl.deploy=true, and copy that marker onto every CLI span as it starts. Existing HTTP baggage propagation carries it to flaps and flyd, whose baggage-copy span processors already annotate their spans. The marker is attached before cmd.deploy starts and remains on child contexts for the command's entire lifetime.With matching sampler routing, marked spans bypass tail sampling individually, including late-arriving spans after the 30-second decision window or cache eviction. Unrelated commands remain unmarked. No dependency changes.
Validation: the full internal/tracing package passes; regression coverage verifies W3C propagation, same trace ID across a simulated backend hop, marked spans with start timestamps older than 30 seconds, and unmarked unrelated spans. The deploy command package compiles. git diff --check passed.
Rollout: deploy sampler routing first, then CLI ingress preservation, then publish this flyctl release. Existing CLI versions do not emit the marker. Existing backend noise filtering and transport limits remain in effect.
Related rollout PRs: https://github.com/superfly/fly-traces-tail-sampler/pull/3, https://github.com/superfly/fly-otel-collector/pull/19.
Lines: code +32/-0, docs +0/-0, tests +47/-0.
Complete rollout order: sampler routing → ingress preservation → flyctl release.