ci(release): restore action/cache release handoff#5748
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@c2c7e8d5be8d324c7579f197d2373dfeebdc6131Preview package for commit |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2c7e8d5be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: | | ||
| packages/cli-*/bin/ | ||
| dist/ | ||
| key: cli-build-${{ github.run_id }}-${{ inputs.shell }}-${{ inputs.version }}${{ inputs.cache_key_suffix }}-v1 |
There was a problem hiding this comment.
Include run_attempt in the cache key
When someone uses “Re-run all jobs” on a release or preview run, GitHub keeps github.run_id the same and only increments github.run_attempt, while actions/cache restores exact-key hits and cache entries are immutable. With this key, the rebuilt artifacts in the producer job are discarded because the lookup sees the previous attempt's cache and the save is skipped; downstream publish/brew/scoop jobs then restore binaries and checksums from the previous attempt rather than the artifacts that were just built. Add github.run_attempt or another per-attempt component to the handoff cache key so reruns cannot publish stale artifacts.
Useful? React with 👍 / 👎.
Summary
Reverts the release workflow handoff from uploaded artifacts back to
actions/cachenow that the repository has more GitHub cache capacity.This restores the previous run-scoped cache keys for CLI build outputs across smoke, publish, Homebrew, Scoop, and preview-package jobs while keeping the newer pinned
actions/cacheversion from the dependency bump.Reverts #5740