Skip to content

ci(release): restore action/cache release handoff#5748

Merged
jgoux merged 2 commits into
developfrom
revert-release-cache-artifacts
Jul 1, 2026
Merged

ci(release): restore action/cache release handoff#5748
jgoux merged 2 commits into
developfrom
revert-release-cache-artifacts

Conversation

@jgoux

@jgoux jgoux commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Reverts the release workflow handoff from uploaded artifacts back to actions/cache now that the repository has more GitHub cache capacity.

This restores the previous run-scoped cache keys for CLI build outputs across smoke, publish, Homebrew, Scoop, and preview-package jobs while keeping the newer pinned actions/cache version from the dependency bump.

Reverts #5740

@jgoux jgoux marked this pull request as ready for review July 1, 2026 09:08
@jgoux jgoux enabled auto-merge July 1, 2026 09:08
@jgoux jgoux added this pull request to the merge queue Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@c2c7e8d5be8d324c7579f197d2373dfeebdc6131

Preview package for commit c2c7e8d.

Merged via the queue into develop with commit bc2f17e Jul 1, 2026
21 checks passed
@jgoux jgoux deleted the revert-release-cache-artifacts branch July 1, 2026 09:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2c7e8d5be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

path: |
packages/cli-*/bin/
dist/
key: cli-build-${{ github.run_id }}-${{ inputs.shell }}-${{ inputs.version }}${{ inputs.cache_key_suffix }}-v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include run_attempt in the cache key

When someone uses “Re-run all jobs” on a release or preview run, GitHub keeps github.run_id the same and only increments github.run_attempt, while actions/cache restores exact-key hits and cache entries are immutable. With this key, the rebuilt artifacts in the producer job are discarded because the lookup sees the previous attempt's cache and the save is skipped; downstream publish/brew/scoop jobs then restore binaries and checksums from the previous attempt rather than the artifacts that were just built. Add github.run_attempt or another per-attempt component to the handoff cache key so reruns cannot publish stale artifacts.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants