Skip to content

Conversation

@dersecure
Copy link
Collaborator

No description provided.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@nielsbasjes
Copy link
Contributor

I would love to do the contributer agreement, but when I submitted it (long ago), it was rejected.
How dowe go from here?

@dersecure
Copy link
Collaborator Author

I would love to do the contributor agreement, but when I submitted it (long ago), it was rejected. How do we go from here?

@Kudrat9 Can we add @nielsbasjes and @altendky to the CLA list? Niels has signed. Has Kyle?

@dersecure
Copy link
Collaborator Author

@Kudrat9 I updated the CLA list in #262 using the current list of contributors. Is that accurate?

@nielsbasjes
Copy link
Contributor

nielsbasjes commented Jun 13, 2025

I had a quick look at the new models and I spotted something that can use a bit of improvement.
The problem as I see it: The unit of the point is only specified in the description.

I see for example in model 64413 (possibly others have the same issue):

{
  "label": "Current",
  "desc": "Current (Amperes)",
  "name": "I",
  "size": 2,
  "type": "float32"
},

I propose to make this something like this

{
  "label": "Current",
  "desc": "Current",
  "name": "I",
  "size": 2,
  "type": "float32",
  "units": "A"
},

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@bikeshedder
Copy link

My user name is @bikeshedder (note the missing r).

It's not about shredding bikes but bikeshedding.

No worries. 😆

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@dersecure dersecure marked this pull request as ready for review June 13, 2025 15:48
@cla-bot cla-bot bot added the cla-signed label Jun 13, 2025
@dersecure dersecure requested a review from Copilot June 13, 2025 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple JSON model files by adding a new "detail" property to group and unit definitions to reference documentation sections and explain special handling, and it adds a CI workflow for XML and JSON validations.

  • Added "detail" properties with reference information in multiple model JSON files.
  • Introduced CI pipelines for XML and JSON validation.

Reviewed Changes

Copilot reviewed 159 out of 159 changed files in this pull request and generated no comments.

Show a summary per file
File Description
json/model_132.json Added "detail" with reference info to group object.
json/model_131.json Added "detail" to group object with updated reference.
json/model_130.json Added "detail" to unit definitions and group object with specific comments.
json/model_129.json Similar "detail" additions with reference update.
json/model_128.json Added "detail" to group object with multiple references.
json/model_127.json Added "detail" to group object with combined references.
json/model_126.json Added "detail" with reference info to group object.
json/model_125.json Added "detail" to group object with revision references.
json/model_124.json Added "detail" to group object with updated reference.
json/model_123.json Added "detail" to group object with multiple reference sections.
json/model_122.json Added "detail" to group and bitfield definitions.
json/model_121.json Added "detail" to unit definitions and group object.
json/model_120.json Added "detail" to unit definitions and group object with extended description.
json/model_113.json Added "detail" to unit definitions.
json/model_112.json Added "detail" to unit definitions.
json/model_111.json Added "detail" to unit definitions.
json/model_103.json Added "detail" to unit definitions.
json/model_102.json Added "detail" to unit definitions.
json/model_101.json Added "detail" to unit definitions.
.github/workflows/ci.yml Introduced a CI pipeline for XML and JSON validation.
Comments suppressed due to low confidence (3)

json/model_132.json:611

  • Ensure that the added 'detail' field (Ref 3: 8.12.1.2) accurately reflects the current documentation specifications and remains consistent with other model files.
"type": "group",

json/model_130.json:504

  • Verify that the detail message for unit 'Secs' clearly differentiates between HVRT and other control types, ensuring consistency with similar models (e.g., LVRT in model_129).
"detail": "Setting is ignored for HVRT controls."

.github/workflows/ci.yml:1

  • Consider adding tests to validate the new 'detail' fields in the JSON models, ensuring they conform to expected formatting and content standards.
name: CI

@dersecure dersecure requested a review from Kudrat9 June 13, 2025 20:01
@Kudrat9 Kudrat9 merged commit 25fbcac into sunspec:master Jun 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants