fix(server): close connection on client Terminate#438
Merged
Conversation
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
sunng87
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro
The frontend message loop matched Terminate ('X') with a catch-all
_ => {}, so the backend never dropped the socket.A client that closes gracefully by sending Terminate and then waiting for the server to close the connection (e.g. asyncpg's Connection.close()) would block forever.
Break out of the read loop on Terminate so the framed socket is dropped and the TCP connection closes, as the protocol requires.