feat: add arithmetic function for bitwise not with decimal arguments#676
Closed
anshuldata wants to merge 2 commits intosubstrait-io:mainfrom
Closed
feat: add arithmetic function for bitwise not with decimal arguments#676anshuldata wants to merge 2 commits intosubstrait-io:mainfrom
anshuldata wants to merge 2 commits intosubstrait-io:mainfrom
Conversation
anshuldata
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua and
westonpace
as code owners
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
anshuldata
force-pushed
the
anshul/BitwiseNotDecimal
branch
from
6e2f1d8 to
06f380b
Compare
anshuldata
changed the title
anshuldata
force-pushed
the
anshul/BitwiseNotDecimal
branch
from
06f380b to
766c0f6
Compare
jacques-n
reviewed
Aug 3, 2024
jacques-n
added
the
awaiting-user-input
anshuldata
force-pushed
the
anshul/BitwiseNotDecimal
branch
4 times, most recently
from
1dfc984 to
c0d2de9
Compare
anshuldata
force-pushed
the
anshul/BitwiseNotDecimal
branch
from
c0d2de9 to
048875e
Compare
jacques-n
approved these changes
Aug 12, 2024
Contributor
jacques-n
left a comment
jacques-n
left a comment
There was a problem hiding this comment.
additional test cases would be good but this is a good start.
|
This PR has been automatically marked as stale because it has not had |
|
This PR has been automatically closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.